media icon indicating copy to clipboard operation
media copied to clipboard

Allow LoadControl.shouldContinueLoading accept playWhenReady as a parameter

Open colinkho opened this issue 1 year ago • 3 comments

Motivation: Load Control requires different min and max buffer values depending if the player is playing or paused.

colinkho avatar May 03 '24 06:05 colinkho

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 03 '24 06:05 google-cla[bot]

Amended commit and force pushed to correct username to allow detection of CLA

colinkho avatar May 03 '24 06:05 colinkho

Thanks, I'll continue the merge process internally and will probably force-push too with additional formatting updates etc.

tonihei avatar May 14 '24 14:05 tonihei

This is merged now. You may have seen it already, but we updated the pull request to move the parameters class inside LoadControl itself and also used it for shouldStartPlayback.

tonihei avatar May 22 '24 10:05 tonihei