Android-CleanArchitecture-Kotlin icon indicating copy to clipboard operation
Android-CleanArchitecture-Kotlin copied to clipboard

Why MovieDetailsAnimator is not injected as a @Singleton?

Open minchaej opened this issue 6 years ago • 0 comments

First of all, thank you so much for this awesome repository.

I have a question about dependency injection: You inject MovieDetailsAnimator @Inject lateinit var movieDetailsAnimator: MovieDetailsAnimator at line 60, MovieDetailsFragment.kt.

And MovieDetailsAnimator is constructed through class MovieDetailsAnimator @Inject constructor()

Wouldn't it be better if MovieDetailsAnimator was constructed with @Singleton annotation? Something like: @Singleton class MovieDetailsAnimator @Inject constructor() It seems like there is no point on getting a new instance of MovieDetailsAnimator for every fragment.

Thank you! 👍

minchaej avatar Sep 14 '19 14:09 minchaej