tv-samples icon indicating copy to clipboard operation
tv-samples copied to clipboard

Published 20 hours ago • verified publisher icon android

Migrate to Jetpack Media3

Open marcbaechinger opened this issue 3 years ago • 4 comments

marcbaechinger avatar Apr 06 '22 19:04 marcbaechinger

@pflammertsma or to whom it may concern :)

I updated this in the fork to Media3 1.0.0-beta01, so it is included in this PR as well. Looks like a good time now to review/merge this PR into the media3 branch. IMO we can also merge into the main branch as the MediaSession API pieces of this app are not too complicated. Up to you regarding the timing of merging into main of course.

marcbaechinger avatar Jun 23 '22 13:06 marcbaechinger

I'm still going through the review, but one curiosity: why have some of the tests in CastHelperTest been removed?

pflammertsma avatar Jul 02 '22 01:07 pflammertsma

Because the method that is under test there have been removed. The underlying API that we called there is not available for Kotlin anymore.

Please see internal bug ref: b/237992143

marcbaechinger avatar Jul 04 '22 11:07 marcbaechinger

I added a commit that changes the life-cycle behaviour as discussed. I made an additional commit on purpose to call this change out so developers can see this specific change to do the right thing.

marcbaechinger avatar Jul 06 '22 15:07 marcbaechinger