sunflower icon indicating copy to clipboard operation
sunflower copied to clipboard

Confusing onCleared in ViewModels

Open LikeAnyan opened this issue 6 years ago • 0 comments

Hi everyone, I'm found a little confuse in current app's ViewModels as there used an viewModelScope from ktx in which implementation coroutine context gets cancel on it's close. But in app's ViewModels onCleared method overriden and there viewModelScope.cancel() call could be found. It looks like onCleared override could be cleaned up from ViewModels as viewModelScope's context cancelation handled by the lib.

references that could be useful: ktx-viewModelScope source, ViewModel source

LikeAnyan avatar Jun 25 '19 22:06 LikeAnyan