nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

Create `Compose compiler metrics` permanent run configuration

Open SimonMarquis opened this issue 2 years ago • 3 comments

This will help devs run the right command, and it's easier to find.

image

SimonMarquis avatar Aug 27 '23 14:08 SimonMarquis

I'm also wondering if it really makes sense to compile both demo and prod build types. Shouldn't it focus only on the prodRelease variant?

SimonMarquis avatar Aug 27 '23 14:08 SimonMarquis

🔔 @mmoczkowski this is a followup on

  • #898

Also, do you have any opinion on my previous comment? (assembleProdRelease/assembleDemoRelease vs assembleRelease)

SimonMarquis avatar Nov 07 '23 21:11 SimonMarquis

I'm not sure that an extra run configuration is necessary here but I'll defer to the Compose team. @bentrengrove what do you think about this approach - is it overkill?

dturner avatar Dec 22 '23 17:12 dturner

Unfortunately, I think this is overkill. There shouldn't be any issue just keeping it permanently enabled. Also, with strong skipping mode coming out soon we don't want to encourage manually annotating too many classes as stable, the compiler reports will still be useful but shouldn't be needed as much as now.

bentrengrove avatar Jan 01 '24 21:01 bentrengrove

Ok, let's close this then 🫡

SimonMarquis avatar Jan 02 '24 10:01 SimonMarquis