nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

[Bug]: Should "bindsUserNewsResourceRepository" be moved to "DataModule"?

Open lelelongwang opened this issue 1 year ago • 3 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Is there a StackOverflow question about this issue?

  • [X] I have searched StackOverflow

What happened?

There is already interface DataModule, should abstract method bindsUserNewsResourceRepository be written in interface DataModule?

Relevant logcat output

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

lelelongwang avatar Aug 16 '23 05:08 lelelongwang

@lelelongwang I agree with you. DataModule already binds all repositories of the :core:data module, except for UserNewsResourceRepository. You can create a PR for that if you want.

SimonMarquis avatar Aug 17 '23 07:08 SimonMarquis

Ok, I'll deal with it soon, thanks for the reply

lelelongwang avatar Aug 17 '23 07:08 lelelongwang

Hi, I am looking to work on open-source projects. I have just started learning Android and jetpack compose. How can I start contributing to issues over here in this repo? Any guidance would be much appreciated.

Code-indomitus avatar Oct 08 '23 10:10 Code-indomitus