nowinandroid
nowinandroid copied to clipboard
[Bug]: Splashscreen theme doesn't change after switching the color theme
Is there an existing issue for this?
- [X] I have searched the existing issues
Is there a StackOverflow question about this issue?
- [X] I have searched StackOverflow
What happened?
Changing the theme from the application settings does not update the theme used on the splash screen.
Steps to reproduce:
- When using a light system theme
- Tap on the settings icon and set the application theme to dark
- Close the application, start it again (with the cold start) and note the splash screen
Expected result: Splash screen should be in dark mode
Actual result: Light splash screen switches to a dark screen of the application.
I think that UiModeManager#setApplicationNightMode should also be called on saving the theme settings as it is described in "Implement dark theme"
Relevant logcat output
No response
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
That's a great idea, we should definitely do that.
Hi may I work on this?
There was a PR open for fixing this (#646), but I just closed it due to inactivity. This is still a relevant issue to be fixed, so if the creator of that PR or someone else would like to fix this please open a new PR.