nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

[Bug]: Splashscreen theme doesn't change after switching the color theme

Open illarionov opened this issue 2 years ago • 3 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Is there a StackOverflow question about this issue?

  • [X] I have searched StackOverflow

What happened?

Changing the theme from the application settings does not update the theme used on the splash screen.

Steps to reproduce:

  • When using a light system theme
  • Tap on the settings icon and set the application theme to dark
  • Close the application, start it again (with the cold start) and note the splash screen

Expected result: Splash screen should be in dark mode

Actual result: Light splash screen switches to a dark screen of the application.

I think that UiModeManager#setApplicationNightMode should also be called on saving the theme settings as it is described in "Implement dark theme"

Relevant logcat output

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

illarionov avatar Mar 22 '23 23:03 illarionov

That's a great idea, we should definitely do that.

alexvanyo avatar Mar 23 '23 00:03 alexvanyo

Hi may I work on this?

Code-indomitus avatar Oct 11 '23 15:10 Code-indomitus

There was a PR open for fixing this (#646), but I just closed it due to inactivity. This is still a relevant issue to be fixed, so if the creator of that PR or someone else would like to fix this please open a new PR.

alexvanyo avatar Dec 15 '23 00:12 alexvanyo