Migrate to testFixtures, closes #451

[SimonMarquis]

[LinX64]

Thanks for the work, and the time you spent :) But I would like to mention something;

I've seen your PRs, and everything seems to be perfect, but I believe you forgot something which is really important and might help all of us in the future, especially the code reviewers. You have many changes on your PRs, which is good, but merging everything into a single commit, doesn't seem to be fine. Imagine someone's trying to code review your PR, and this becomes a problem with 22 files changed inside a single commit.

What do you think if we separate the changes into single commits and merge ONLY those which are related to each other at the end of the work before pushing? This way, it will make it much easier to code review and check the changes.

[SimonMarquis]

merging everything into a single commit, doesn't seem to be fine

Well, for such changes (like migrations) I don't see the point of it, at all. Splitting these kind of PR into multiple commits, each migrating a file (or module) wont make it more "readable" for the reviewer.

What do you think if we separate the changes into single commits and merge ONLY those which are related to each other at the end of the work before pushing?

Again, the changes of this PR is well scoped. I did not changed any behavior of the codebase.

The only thing that would make sense to split is:

• one commit adding the testFixtures
• another one replacing all usages 🤷

[mmoczkowski]

Closing due to inactivity. If you still wish to submit this change, please create a new PR.

[SimonMarquis]

For anyone interested in updates, I've pushed a new PR that enables "almost" proper Android test fixtures thanks to AGP 8.5.0:

• #1515