nowinandroid
nowinandroid copied to clipboard
New empty bookmarks handling
This is a new PR for the saved screen. Replacement for this PR.
The output after the code review and replaced vector:

You can export the greyscale icon instead, that imports successfully. Then you can use the tint parameter to give it the right themed color!
Not sure what was the issue with Spotless, however, here is the error:
> The following files had format violations: src/main/java/com/google/samples/apps/nowinandroid/feature/bookmarks/BookmarksScreen.kt @@ -156,6 +156,5 @@ ············textAlign·=·TextAlign.Center, ············style·=·MaterialTheme.typography.bodyMedium ········) - ····} -} +}
Any hints would be appreciated.
Run ./gradlew spotlessApply
@LinX64
I see a command in workflow file, and change check
to apply
./gradlew spotlessApply --init-script gradle/init.gradle.kts --no-configuration-cache
I'm rewriting the BookmarksScreen file a bit to be more readable, will push to this branch and would love to hear your thoughts!
Can you allow me to push to your fork so I can push my changes? See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
If we're talking about the Allow edits by maintainers
option, it is already checked, so you should be able to push to this branch.
@LinX64 Thank you for your contribution, it's much appreciated! Code looks great :)