nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

New empty bookmarks handling

Open LinX64 opened this issue 2 years ago • 6 comments

This is a new PR for the saved screen. Replacement for this PR.

The output after the code review and replaced vector:

LinX64 avatar Nov 17 '22 15:11 LinX64

You can export the greyscale icon instead, that imports successfully. Then you can use the tint parameter to give it the right themed color!

JolandaVerhoef avatar Nov 17 '22 16:11 JolandaVerhoef

Not sure what was the issue with Spotless, however, here is the error:

> The following files had format violations:
      src/main/java/com/google/samples/apps/nowinandroid/feature/bookmarks/BookmarksScreen.kt
          @@ -156,6 +156,5 @@
           ············textAlign·=·TextAlign.Center,
           ············style·=·MaterialTheme.typography.bodyMedium
           ········)
          -
           ····}
          -}
          +}

Any hints would be appreciated.

Run ./gradlew spotlessApply

hoc081098 avatar Nov 18 '22 15:11 hoc081098

@LinX64 I see a command in workflow file, and change check to apply

./gradlew spotlessApply --init-script gradle/init.gradle.kts --no-configuration-cache

hoc081098 avatar Nov 18 '22 16:11 hoc081098

I'm rewriting the BookmarksScreen file a bit to be more readable, will push to this branch and would love to hear your thoughts!

JolandaVerhoef avatar Nov 18 '22 16:11 JolandaVerhoef

Can you allow me to push to your fork so I can push my changes? See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

JolandaVerhoef avatar Nov 18 '22 16:11 JolandaVerhoef

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

If we're talking about the Allow edits by maintainers option, it is already checked, so you should be able to push to this branch.

LinX64 avatar Nov 18 '22 16:11 LinX64

@LinX64 Thank you for your contribution, it's much appreciated! Code looks great :)

JolandaVerhoef avatar Nov 20 '22 08:11 JolandaVerhoef