nowinandroid
nowinandroid copied to clipboard
Add NiaTopicTag chip interaction
https://user-images.githubusercontent.com/55670723/201496584-fd8dff25-2d70-4fb3-b273-cb9b45412a57.mp4
Tests succeeded on my computer 🤔
Retrying build to see if it failed due to flakiness
Thank you for your contribution Yves.
@dturner is this aligned with our design specs?
I think we should hold off on merging this one.
I previously took out this functionality because it's not accessible by design. Following / Unfollowing a topic causes the whole screen to refresh.
@yveskalume
Instead of having a drop down menu for the topic chips, what do you think about just navigating to browse the topic if the topic chip is clicked on? That would be a more accessible user experience.
I also think it's the best idea. So can I do that ?
@yveskalume if you can update this PR to do what's described in https://github.com/android/nowinandroid/pull/429#issuecomment-1317610260, that'd be great!
@calren it's done !
Hmm it looks like there are some files included in the diff that's not part of this PR, probably because of the merge with main
branch? Do you mind getting that sorted out? Feel free to just open a new PR with your changes if that's easier.
Great, so let's close this one !
@calren I've open #444