nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

Add NiaTopicTag chip interaction

Open yveskalume opened this issue 2 years ago • 9 comments

https://user-images.githubusercontent.com/55670723/201496584-fd8dff25-2d70-4fb3-b273-cb9b45412a57.mp4

yveskalume avatar Nov 12 '22 22:11 yveskalume

Tests succeeded on my computer 🤔

yveskalume avatar Nov 14 '22 17:11 yveskalume

Retrying build to see if it failed due to flakiness

mmoczkowski avatar Nov 15 '22 10:11 mmoczkowski

Thank you for your contribution Yves.

@dturner is this aligned with our design specs?

mmoczkowski avatar Nov 15 '22 10:11 mmoczkowski

I think we should hold off on merging this one.

I previously took out this functionality because it's not accessible by design. Following / Unfollowing a topic causes the whole screen to refresh.

calren avatar Nov 16 '22 20:11 calren

@yveskalume

Instead of having a drop down menu for the topic chips, what do you think about just navigating to browse the topic if the topic chip is clicked on? That would be a more accessible user experience.

calren avatar Nov 16 '22 20:11 calren

I also think it's the best idea. So can I do that ?

yveskalume avatar Nov 17 '22 04:11 yveskalume

@yveskalume if you can update this PR to do what's described in https://github.com/android/nowinandroid/pull/429#issuecomment-1317610260, that'd be great!

calren avatar Nov 17 '22 05:11 calren

@calren it's done !

yveskalume avatar Nov 17 '22 10:11 yveskalume

Hmm it looks like there are some files included in the diff that's not part of this PR, probably because of the merge with main branch? Do you mind getting that sorted out? Feel free to just open a new PR with your changes if that's easier.

calren avatar Nov 17 '22 16:11 calren

Great, so let's close this one !

yveskalume avatar Nov 17 '22 20:11 yveskalume

@calren I've open #444

yveskalume avatar Nov 17 '22 21:11 yveskalume