[Bug]: Onboarding "Done" text is tiny

[dturner]

Is there an existing issue for this?

• [X] I have searched the existing issues

Is there a StackOverflow question about this issue?

• [X] I have searched StackOverflow

What happened?

The text on the "Done" button is tiny. It shouldn't be.

Relevant logcat output

No response

Code of Conduct

• [X] I agree to follow this project's Code of Conduct

[SimonMarquis]

What would be the appropriate style?

https://github.com/android/nowinandroid/blob/e72e31b1f013676a10b4ecc6f83606a51141e862/feature/foryou/src/main/java/com/google/samples/apps/nowinandroid/feature/foryou/ForYouScreen.kt#L270-L272

MaterialTheme.typography.bodyMedium maybe?

[SimonMarquis]

Default	bodySmall	bodyMedium	bodyLarge

[SimonMarquis]

Though it seems like the NiaFilledButton (and NiaOutlinedButton) are always using MaterialTheme.typography.labelSmall without checking the value of the boolean parameter small.

https://github.com/android/nowinandroid/blob/e72e31b1f013676a10b4ecc6f83606a51141e862/core/designsystem/src/main/java/com/google/samples/apps/nowinandroid/core/designsystem/component/Button.kt#L73-L77

Maybe the better fix would be to do:

        content = {
-            ProvideTextStyle(value = MaterialTheme.typography.labelSmall) {
+            ProvideTextStyle(value = if (small) MaterialTheme.typography.labelSmall else MaterialTheme.typography.labelMedium) {
                content()
            }
        }

[SimonMarquis]

@dturner this has been fixed, you can close the issue :)

[SimonMarquis]

This issue has been fixed, we can close the issue.