nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

Multiple warnings during build

Open dturner opened this issue 3 years ago • 2 comments

Steps to repro:

./gradlew testDemoDebugUnitTest

Expected result:

No warnings

Actual result:

$ ./gradlew testDemoDebugUnitTest
Starting a Gradle Daemon, 1 busy and 1 incompatible Daemons could not be reused, use --status for details
Configuration cache is an incubating feature.
Calculating task graph as no configuration cache is available for tasks: testDemoDebugUnitTest

> Task :core:ui:compileDemoDebugKotlin
w: /Users/donturner/Code/workspace-android/nowinandroid/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCard.kt: (255, 5): Parameter 'newsResource' is never used

> Task :app:processDemoDebugMainManifest
/Users/donturner/Code/workspace-android/nowinandroid/app/src/main/AndroidManifest.xml Warning:
        meta-data#com.google.samples.apps.nowinandroid.sync.initializers.SyncInitializer was tagged at AndroidManifest.xml:0 to remove other declarations but no other declaration present

> Task :core:navigation:kaptDemoDebugKotlin
warning: The following options were not recognized by any processor: '[dagger.fastInit, dagger.hilt.android.internal.disableAndroidSuperclassValidation, dagger.hilt.internal.useAggregatingRootProcessor, kapt.kotlin.generated]'

> Task :core:datastore-test:kaptDemoDebugKotlin
warning: unknown enum constant NiaDispatchers.IO
  reason: class file for com.google.samples.apps.nowinandroid.core.network.NiaDispatchers not found
warning: unknown enum constant NiaDispatchers.IO
  reason: class file for com.google.samples.apps.nowinandroid.core.network.NiaDispatchers not found
warning: unknown enum constant NiaDispatchers.IO
  reason: class file for com.google.samples.apps.nowinandroid.core.network.NiaDispatchers not found
warning: unknown enum constant NiaDispatchers.IO
  reason: class file for com.google.samples.apps.nowinandroid.core.network.NiaDispatchers not found

> Task :core:data-test:kaptDemoDebugKotlin
warning: unknown enum constant NiaDispatchers.IO
  reason: class file for com.google.samples.apps.nowinandroid.core.network.NiaDispatchers not found
warning: unknown enum constant NiaDispatchers.IO
warning: unknown enum constant NiaDispatchers.IO
warning: unknown enum constant NiaDispatchers.IO
  reason: class file for com.google.samples.apps.nowinandroid.core.network.NiaDispatchers not found
warning: unknown enum constant NiaDispatchers.IO
warning: unknown enum constant NiaDispatchers.IO
warning: unknown enum constant NiaDispatchers.IO
  reason: class file for com.google.samples.apps.nowinandroid.core.network.NiaDispatchers not found
warning: unknown enum constant NiaDispatchers.IO
warning: unknown enum constant NiaDispatchers.IO
warning: unknown enum constant NiaDispatchers.IO
  reason: class file for com.google.samples.apps.nowinandroid.core.network.NiaDispatchers not found
warning: unknown enum constant NiaDispatchers.IO
warning: unknown enum constant NiaDispatchers.IO

dturner avatar Oct 25 '22 11:10 dturner

@dturner, regarding the SyncInitializer:

> Task :app:processDemoDebugMainManifest
/Users/donturner/Code/workspace-android/nowinandroid/app/src/main/AndroidManifest.xml Warning:
        meta-data#com.google.samples.apps.nowinandroid.sync.initializers.SyncInitializer was tagged at AndroidManifest.xml:0 to remove other declarations but no other declaration present

The issue comes from the fact that it is added to AndroidManifest.xml in the main sourceSet and removed in the demo sourceSet. The solution (which to me would be more logical as well), is to simply only add it to the prod sourceSet. What do you think? I can create the PR you are ok with this change: https://github.com/android/nowinandroid/compare/main...SimonMarquis:nowinandroid:fix/warnings-SyncNotificationsService

SimonMarquis avatar May 27 '23 10:05 SimonMarquis

@dturner these warnings no longer appear in the builds, and we could close this issue. For example, on the main branch: https://github.com/android/nowinandroid/actions/runs/7293932999/job/19877989740

SimonMarquis avatar Dec 22 '23 10:12 SimonMarquis