nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

Published 20 hours ago • verified publisher icon android

Update SettingsViewModel.kt

Open yannigoyal opened this issue 7 months ago • 3 comments

What I have done and why

  • Used setApplicationNightMode via UiModeManager for API 31+ (Android 12+).
  • Used AppCompatDelegate.setDefaultNightMode for below API 31.
  • Ensures consistent dark theme behaviour across all Android versions.

yannigoyal avatar Apr 23 '25 17:04 yannigoyal

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 23 '25 17:04 google-cla[bot]

Please read the instructions for submitting a pull request.

dturner avatar Apr 23 '25 18:04 dturner

@dturner I've read all the instructions now — since this is my first PR, I initially missed them. I've updated the comment accordingly. Let me know if any further changes are needed.

yannigoyal avatar Apr 24 '25 06:04 yannigoyal

@yannigoyal Thanks for updating this PR. You'll need to sign the CLA before we can accept it.

dturner avatar Jul 11 '25 08:07 dturner