nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

Published 20 hours ago • verified publisher icon android

[Clean-up] Add clean-up for SearchViewModel.

Open iamjosephmj opened this issue 10 months ago • 2 comments

What I have done and why

Remove private val modifier from searchContentsRepository variable inside SearchViewModel

iamjosephmj avatar Jan 26 '25 21:01 iamjosephmj

Why are you removing private val? Anything needs to be access `searchContentsRepository ?

Jaehwa-Noh avatar Feb 06 '25 12:02 Jaehwa-Noh

Why are you removing private val? Anything needs to be access `searchContentsRepository ?

@Jaehwa-Noh Thankyou for looking into the PR. On the day I raised the PR, searchContentsRepository was only consumed by searchResultUiState.

Screenshot 2025-02-06 133920

Because of that reason, the studio was showing a lint warning as well

Screenshot 2025-02-06 134141

iamjosephmj avatar Feb 06 '25 12:02 iamjosephmj