nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

[FR]: Suggest changing the UI layer injection method of Analytics Instance in Analytics Module.

Open rhkrwngud445 opened this issue 1 year ago • 1 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Describe the problem

Suggest changing the UI layer injection method of Analytics Instance in Analytics Module.

Instead of using CompositionLocal, how about using Hilt's EntryPoint?

It has these advantages.

  1. It has the advantage of reducing MainActivity injection code.
  2. Management outside HiltScope can be reduced.
  3. Analytics can eliminate compose dependency.

Additionally, in analytics/AnalyticsModule, how about creating an instance as a singleton?

Describe the solution

Change Injection of CompositionLocal to Hilt's EntryPoint

Additional context

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

rhkrwngud445 avatar May 26 '24 08:05 rhkrwngud445

Get newer

Pandabar007 avatar May 26 '24 12:05 Pandabar007