nowinandroid
nowinandroid copied to clipboard
android
Add swipe gesture to Tabs in Interests screen
closes #53
I have used Horizontal Pager from the Acompanist Library to implement this swipe feature.
https://user-images.githubusercontent.com/55763604/170365872-0d3e3ae7-0057-4fad-bd48-ba8af13a51b3.mp4
Can you run ./gradlew spotlessApply to fix the formatting issues in the code?
LGTM with a minor nit comment, also needs to resolve the conflicts and it's good to go :) thank you!
Would it be possible to fix the conflicts and the build? Behavior-wise this PR looks great, so let's try to get it merged!
I fixed the conflicts but I have no idea about the error that appeared in the workflow. I don't think it is because of my code.
Your changes introduced some code formatting issues which are being flagged by spotless. This is causing the build to fail. Please run: ./gradlew spotlessApply to fix these issues.
There seems to be a failing UI test. We'll have to investigate before we can merge.
Apologies for letting this go unmerged for so long. If you could just fix the merge conflicts I will merge asap.
Hi I was also able to reproduce the error locally. I'm not understanding it though, like why tab is not being displayed during test. I haven't worked with UI testing before so I'm not sure on how it works. Do I need to rewrite the test code or do I have to make changes in my swipe implementation. Because in the app it works smoothly but the failing for test specifically.
Sorry for all the back on forth on this PR. In the end we decided to remove authors as it wasn't adding a lot of user value, which makes this PR redundant. We'll try to find somewhere else in the app where we can use tabs to show off the swipe gesture.
Thanks again for your contribution.