nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

Nightly builds with baseline profiles

Open keyboardsurfer opened this issue 1 year ago • 12 comments

Change-Id: I162cd9eca724c30d839add912359482cbce7c68e

Thanks for submitting a pull request. Please include the following information.

What I have done and why Enabled baseline profile generation for new nightly build type. With KVM, GMD run smoothly and BP generation is not negatively affected any longer. Enabling nightly builds for this keeps PR builds fast while allowing for baseline profiles to be generated regularly as well.

Fixes #<issue_number_goes_here>

Do tests pass?

  • [X] Run local tests on DemoDebug variant: ./gradlew testDemoDebug
  • [X] Check formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

keyboardsurfer avatar Jan 22 '24 14:01 keyboardsurfer

RFR. @JoseAlcerreca & @dturner PTAL.

keyboardsurfer avatar Jan 24 '24 15:01 keyboardsurfer

Combined test coverage report

Overall Project 40.4% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Apr 19 '24 07:04 github-actions[bot]

Combined test coverage report

Overall Project 40.4% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Apr 22 '24 12:04 github-actions[bot]

Combined test coverage report

Overall Project 40.4% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Apr 23 '24 11:04 github-actions[bot]

@JoseAlcerreca could this be a flaky test?

com.google.samples.apps.nowinandroid.ui.SnackbarScreenshotTests > snackbarShown_tablet FAILED
    java.lang.AssertionError at SnackbarScreenshotTests.kt:236

If so, could you show me how to fix it or approve the PR so it can be merged?

keyboardsurfer avatar Apr 23 '24 13:04 keyboardsurfer

Let's merge #1395 first and make sure this one passes

JoseAlcerreca avatar Apr 24 '24 08:04 JoseAlcerreca

SGTM

keyboardsurfer avatar Apr 24 '24 10:04 keyboardsurfer

Combined test coverage report

Overall Project 40.37% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Apr 24 '24 18:04 github-actions[bot]

Combined test coverage report

Overall Project 40.4% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Apr 24 '24 18:04 github-actions[bot]

Combined test coverage report

Overall Project 40.4% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Apr 25 '24 10:04 github-actions[bot]

Combined test coverage report

Overall Project 40.4% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Apr 25 '24 12:04 github-actions[bot]

Combined test coverage report

Overall Project 40.4% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Apr 25 '24 13:04 github-actions[bot]

Combined test coverage report

Overall Project 42.34% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 05 '24 14:09 github-actions[bot]

Combined test coverage report

Overall Project 42.34% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 05 '24 15:09 github-actions[bot]

Combined test coverage report

Overall Project 42.31% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 05 '24 18:09 github-actions[bot]

I just wonder this, the baseline profile is recommended run on real device, not emulator. Is this CI based Android baseline profile has a value?

Jaehwa-Noh avatar Sep 05 '24 23:09 Jaehwa-Noh

I just wonder this, the baseline profile is recommended run on real device, not emulator. Is this CI based Android baseline profile has a value?

Measuring performance requires a physical device to create accurate results. Generating a baseline profile does not require a physical device as it's not about timing but exercising the app and collecting methods and classes in the process.

keyboardsurfer avatar Sep 09 '24 10:09 keyboardsurfer

Combined test coverage report

Overall Project 42.31% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 09 '24 10:09 github-actions[bot]

Combined test coverage report

Overall Project 42.34% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 10 '24 08:09 github-actions[bot]

Combined test coverage report

Overall Project 42.29% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 10 '24 09:09 github-actions[bot]

Combined test coverage report

Overall Project 42.34% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 10 '24 09:09 github-actions[bot]

Combined test coverage report

Overall Project 42.31% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 10 '24 11:09 github-actions[bot]

Combined test coverage report

Overall Project 42.22% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 10 '24 12:09 github-actions[bot]

Combined test coverage report

Overall Project 42.35% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 11 '24 11:09 github-actions[bot]

Combined test coverage report

Overall Project 42.35% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 11 '24 12:09 github-actions[bot]

Combined test coverage report

Overall Project 42.35% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 11 '24 12:09 github-actions[bot]

Combined test coverage report

Overall Project 42.32% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 11 '24 13:09 github-actions[bot]

Combined test coverage report

Overall Project 42.35% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 12 '24 07:09 github-actions[bot]

Combined test coverage report

Overall Project 42.32% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 12 '24 08:09 github-actions[bot]

Combined test coverage report

Overall Project 42.35% :green_apple:

There is no coverage information present for the Files changed

github-actions[bot] avatar Sep 12 '24 08:09 github-actions[bot]