nowinandroid
nowinandroid copied to clipboard
Nightly builds with baseline profiles
Change-Id: I162cd9eca724c30d839add912359482cbce7c68e
Thanks for submitting a pull request. Please include the following information.
What I have done and why Enabled baseline profile generation for new nightly build type. With KVM, GMD run smoothly and BP generation is not negatively affected any longer. Enabling nightly builds for this keeps PR builds fast while allowing for baseline profiles to be generated regularly as well.
Fixes #<issue_number_goes_here>
Do tests pass?
- [X] Run local tests on
DemoDebug
variant:./gradlew testDemoDebug
- [X] Check formatting:
./gradlew --init-script gradle/init.gradle.kts spotlessApply
RFR. @JoseAlcerreca & @dturner PTAL.
Combined test coverage report
Overall Project | 40.4% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 40.4% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 40.4% | :green_apple: |
---|
There is no coverage information present for the Files changed
@JoseAlcerreca could this be a flaky test?
com.google.samples.apps.nowinandroid.ui.SnackbarScreenshotTests > snackbarShown_tablet FAILED
java.lang.AssertionError at SnackbarScreenshotTests.kt:236
If so, could you show me how to fix it or approve the PR so it can be merged?
Let's merge #1395 first and make sure this one passes
SGTM
Combined test coverage report
Overall Project | 40.37% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 40.4% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 40.4% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 40.4% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 40.4% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.34% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.34% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.31% | :green_apple: |
---|
There is no coverage information present for the Files changed
I just wonder this, the baseline profile is recommended run on real device, not emulator. Is this CI based Android baseline profile has a value?
I just wonder this, the baseline profile is recommended run on real device, not emulator. Is this CI based Android baseline profile has a value?
Measuring performance requires a physical device to create accurate results. Generating a baseline profile does not require a physical device as it's not about timing but exercising the app and collecting methods and classes in the process.
Combined test coverage report
Overall Project | 42.31% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.34% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.29% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.34% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.31% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.22% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.35% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.35% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.35% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.32% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.35% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.32% | :green_apple: |
---|
There is no coverage information present for the Files changed
Combined test coverage report
Overall Project | 42.35% | :green_apple: |
---|
There is no coverage information present for the Files changed