nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

Published 20 hours ago • verified publisher icon android

Rename FollowedInterestsState to FollowedInterestsUiState

Open madroidmaq opened this issue 3 years ago • 1 comments

read more: #42

madroidmaq avatar Jun 06 '22 00:06 madroidmaq

The build is failing due to some unresolved references to the UiState. Can you take a look?

JolandaVerhoef avatar Jul 25 '22 10:07 JolandaVerhoef

@JolandaVerhoef I tried many times and basically it gets cancelled during the execution of the Android UnitTest (suspect that it might be taking too long to execute). Is there any way I can pass the CI check? image

madroidmaq avatar Aug 15 '22 01:08 madroidmaq

I was recently looking at ForYouViewModel trying to understand where each UiState variable was used in ForYouScreen. It turns out that FollowedInterestsUiState isn't used for UI state at all. It's an intermediate private variable used by other combine functions to construct UI state. With this in mind, I don't think it should have Ui in its suffix.

dturner avatar Oct 27 '22 15:10 dturner