databinding-samples
databinding-samples copied to clipboard
android
Fix issue #2
@JoseAlcerreca I actually don't know how to approach this, I didn't contribute before so much. This fix the problem stated at issue #2 . Let me know if further modification needed. ~~I think some refactoring could be done on ViewModels to move out the duplicate parts.~~ Refactored a little bit as popularity decision logic based on like count is common on both ProfileObservableViewModel and ProfileObservableFieldsViewModel.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
@diwakarsinghdiwakar this branch is updated and the conflicts are resolved. I believe this is now ready to be merged.
@codingjeremy should we close it or there is still chances to get it merged.