connectivity-samples icon indicating copy to clipboard operation
connectivity-samples copied to clipboard

Fixed: Added Runtime permission to support API 23

Open codingjeremy opened this issue 6 years ago • 6 comments

Issue by dzwiedziu-nkg Tuesday Jun 28, 2016 at 09:43 GMT Originally opened as https://github.com/android/android-BluetoothLeGatt/pull/20


prof18 added Runtime permission to support API 23 but he included many unnecessary files that should be listed in .gitignore. I made clean and minimalistic patch.

I tested my patch on Samsung Galaxy S4 with CyanogenMod 13 (based on Android 6.0) and Nexus 9 with Android N Preview. I not tested on native device with Android older than 6.0 but it should works because I checks android version before go into modified code and run it only on >= 6.0.


dzwiedziu-nkg included the following code: https://github.com/android/android-BluetoothLeGatt/pull/20/commits

codingjeremy avatar Sep 17 '19 00:09 codingjeremy

Comment by googlebot Tuesday Jun 28, 2016 at 09:43 GMT


Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

codingjeremy avatar Sep 17 '19 00:09 codingjeremy

Comment by dzwiedziu-nkg Tuesday Jun 28, 2016 at 09:47 GMT


I signed it!

codingjeremy avatar Sep 17 '19 00:09 codingjeremy

Comment by googlebot Tuesday Jun 28, 2016 at 09:47 GMT


CLAs look good, thanks!

codingjeremy avatar Sep 17 '19 00:09 codingjeremy

Comment by MarkOSullivan94 Tuesday Jul 12, 2016 at 14:00 GMT


Would be great if this pull request was accepted, I had issues with getting this example project working recently and it was due to the run time permissions being missing.

codingjeremy avatar Sep 17 '19 00:09 codingjeremy

Comment by runephilosof Friday Oct 28, 2016 at 08:31 GMT


Odd that Google doesn't prioritize this. Maybe some tests should be added to the code so that the samples can be checked for compliance and, if necessary, fixed before new android versions are released.

codingjeremy avatar Sep 17 '19 00:09 codingjeremy

Comment by fmatosqg Thursday Aug 10, 2017 at 08:36 GMT


Solving merge conflict on PR #41

codingjeremy avatar Sep 17 '19 00:09 codingjeremy