compose-samples icon indicating copy to clipboard operation
compose-samples copied to clipboard

[Bug]: Jetcaster does not show any podcasts and doesn't respond to keyboard input

Open dturner opened this issue 1 year ago • 4 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Is there a StackOverflow question about this issue?

  • [X] I have searched StackOverflow

Is this an issue related to one of the samples?

  • [X] Yes, this is a specific issue related to this samples repo.

Sample app

Jetcaster

What happened?

When running Jetcaster on the emulator, the app does not show any podcasts (which presumably it is supposed to), and when attempting to enter text into the search field, no text appears.

Screen_recording_20240909_154310.webm

Relevant logcat output

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

dturner avatar Sep 09 '24 14:09 dturner

I think there are 2 issues here.

Re loading podcasts, I ran the app on a couple of devices, including some emulators. On one of the emulators it did take a good few seconds to load podcasts, but they eventually did load, so at this moment I don't have a repro case. @dturner do the podcasts eventually load, or is it blank indefinitely?

Re the search bar, it seems we just never update the text as you type, it's always just "". That much is a quick fix, but the app doesn't have any actual search or text-matching logic, so it won't impact what items are displayed.

jdkoren avatar Sep 09 '24 17:09 jdkoren

I'm getting a NetworkOnMainThreadException when fetching the podcasts, which filters all feeds down to an empty list, so the selectedCategory won't get updated, and discoverItems() just returns without adding any UI.

(I added a breakpoint at PodcastFetcher:83)

javadude avatar Sep 09 '24 20:09 javadude

The same issue occurs on the TV app. Fix proposed by @javadude in #1463 fixed the issue.

Loic-Dumas avatar Sep 11 '24 11:09 Loic-Dumas

@jdkoren stays blank indefinitely

I'm getting a NetworkOnMainThreadException when fetching the podcasts

Presumably that exception was getting caught. Be better to throw the NetworkOnMainThreadException and cause a runtime crash than silently fail, which is what is currently happening.

dturner avatar Sep 11 '24 14:09 dturner

I think there are 2 issues here...

Both of these have been addressed, so closing this issue.

jdkoren avatar Oct 15 '24 21:10 jdkoren