compose-samples icon indicating copy to clipboard operation
compose-samples copied to clipboard

Added Modal Bottomsheet implementation

Open Gurupreet opened this issue 2 years ago • 2 comments

Add Material 3 bottom sheet implementation with adaptive guidance.

Screenshot 2023-12-06 at 2 28 10 PM Screenshot 2023-12-06 at 2 28 26 PM Screenshot 2023-12-06 at 2 28 39 PM

Gurupreet avatar Dec 06 '23 13:12 Gurupreet

It looks like the three issues with bottom sheet that I called out are tracked:

1: https://issuetracker.google.com/231606426 2: https://issuetracker.google.com/314130413 3: https://issuetracker.google.com/278679016

So we can ignore those for this project

IanGClifton avatar Dec 09 '23 01:12 IanGClifton

It looks like state is not being preserved in the bottom sheet when the navigation UI switches, due to the bottom sheet being called in two distinct code locations:

https://github.com/android/compose-samples/assets/4217560/44c6fb8e-ea22-4d8b-8705-e61eee988cf3

alexvanyo avatar Dec 11 '23 17:12 alexvanyo

This issue has been automatically marked as stale because it has not had any recent activity. Please comment here if it is still valid so that we can reprioritize it. Thank you for your contributions.

stale[bot] avatar Feb 29 '24 01:02 stale[bot]