architecture-templates icon indicating copy to clipboard operation
architecture-templates copied to clipboard

Published 20 hours ago • verified publisher icon android

Pluralise MyModel for Screen and ViewModel

Open dturner opened this issue 2 years ago • 2 comments

The existing MyModelScreen actually shows a list of MyModels rather than a single MyModel. This PR pluralises the Screen and ViewModel class names to more accurately describe what the UI is doing.

dturner avatar Dec 16 '22 19:12 dturner

Have you checked all remaining instances of MyModel ? I guess some of them must stay singular. Did you take that into account in the script?

JoseAlcerreca avatar Dec 19 '22 09:12 JoseAlcerreca

The objects which don't need renaming are MyModelRepository, MyModelDao, MyModel and the test classes associated with these objects. These have not been renamed as part of this PR.

Did I miss something?

Also, if/when this is merged we should update the multimodule branch with these changes as well.

dturner avatar Jan 04 '23 14:01 dturner