architecture-samples icon indicating copy to clipboard operation
architecture-samples copied to clipboard

Pull to refresh doesn't work when there are no tasks

Open dturner opened this issue 2 years ago • 3 comments

Steps to repro:

  • Load app, delete any existing tasks so that "You have no tasks!" is displayed
  • swipe vertically downwards

Expected outcome

  • The loading spinner is displayed

Actual outcome

  • Nothing happens

Further details:

Pull to refresh is implemented in the LoadingContent composable. This either displays empty content or if it is non empty (specified by the logic tasks.isEmpty() && !loading) a container which supports pull to refresh.

So the problem is that the empty content should be displayed inside a container which supports pull to refresh.

Additionally the code is currently using SwipeRefresh from the accompanist library which is deprecated and needs migrating https://google.github.io/accompanist/swiperefresh/#migration

dturner avatar Mar 14 '23 22:03 dturner

@dturner Please review the issue as addressed here in this PR https://github.com/android/architecture-samples/pull/934. Thank you

AnirudhPudari avatar Mar 27 '23 11:03 AnirudhPudari

@dturner @manuelvicnt @tunjid Please take a look and review this PR https://github.com/android/architecture-samples/pull/934. Thank you

AnirudhPudari avatar Apr 08 '23 15:04 AnirudhPudari

Sorry for the delay. Please fix the spotless formatting on the PR.

dturner avatar Jun 05 '23 15:06 dturner