android
SwipeRefreshLayout.setOnRefreshListener should force update
on todo-mvp-kotlin and todo-mvp-rxjava the TasksFragment's SwipeRefreshLayout.setOnRefreshListener call always has { presenter.loadTasks(forceUpdate = false) }
I'm wondering if I'm misunderstanding the code but wouldn't you expect a "pull to refresh" action to query the network?
You're right to question that behavior — your understanding is valid.
In both todo-mvp-kotlin and todo-mvp-rxjava, the call:
swipeRefreshLayout.setOnRefreshListener { presenter.loadTasks(forceUpdate = false) } should indeed use forceUpdate = true.
Why? Pull-to-refresh is explicit user intent to refresh data. So it should bypass any cached or local data and force a fresh fetch from the source (typically network or latest data provider).
Correct usage: Update it to:
swipeRefreshLayout.setOnRefreshListener { presenter.loadTasks(forceUpdate = true) } Summary: Yes — the issue is valid. The current implementation contradicts standard UX expectations. A pull-to-refresh should always invoke a forced update.
