architecture-components-samples
architecture-components-samples copied to clipboard
android
Update NetworkBoundResource.kt
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ️ Googlers: Go here for more info.
result.addSource() needs to be called on the main thread in case of the other call (ApiSuccessResponse case).
Is this because loadFromDb() is already on main thread? I don't understand why there is a distinction.
Is this because loadFromDb() is already on main thread? I don't understand why there is a distinction.
https://github.com/googlesamples/android-architecture-components/blob/523ea80ed325f637bca3ee6d36f56442ad4f5219/GithubBrowserSample/app/src/main/java/com/android/example/github/repository/NetworkBoundResource.kt#L48
https://github.com/googlesamples/android-architecture-components/blob/523ea80ed325f637bca3ee6d36f56442ad4f5219/GithubBrowserSample/app/src/main/java/com/android/example/github/repository/NetworkBoundResource.kt#L67
fetchFromNetwork() is already on main thread, so we need not switch to main thread any more.