android-ktx icon indicating copy to clipboard operation
android-ktx copied to clipboard

Bitmap extensions

Open feiyanke opened this issue 7 years ago • 6 comments

some useful functions of Bitmap:

Bitmap.toBytes
Bitmap.clip
Bitmap.skew
Bitmap.rotate

feiyanke avatar Mar 09 '18 07:03 feiyanke

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot avatar Mar 09 '18 07:03 googlebot

I signed it!

feiyanke avatar Mar 09 '18 08:03 feiyanke

CLAs look good, thanks!

googlebot avatar Mar 09 '18 08:03 googlebot

I'm liking toBytes, but it really should be toByteArray. Also, I'm not sure if JPG shoud be the default format over PNG. And maybe use IntRange annotation in param quality.

hanggrian avatar Mar 09 '18 08:03 hanggrian

@hendraanggrian It more make sense to use toByteArray, I have fixed it and added IntRange for quality. PNG is a common use format, but I perfer JPG as it could make smaller size for most bitmaps.

feiyanke avatar Mar 12 '18 01:03 feiyanke

I am not against those two extensions, they are actually kind of useful, but they don't really leverage any feature of Kotlin, beyond being simple extensions. rotate with a default pivot point would.

romainguy avatar Jun 08 '18 19:06 romainguy