android-ktx icon indicating copy to clipboard operation
android-ktx copied to clipboard

Add SeekBar listener extensions

Open bernaferrari opened this issue 7 years ago • 3 comments

Two things to notice:

  • I was only able to make the test for onProgressChanged, since onStartTrackingTouch and onStopTrackingTouch deal directly with UI and private methods.
  • I'm not sure the name from a method is the best one. The original is "onStartTrackingTouch", I made it become "onStartTracking", is this ok?

bernaferrari avatar Feb 06 '18 01:02 bernaferrari

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot avatar Feb 06 '18 01:02 googlebot

I signed it!

bernaferrari avatar Feb 06 '18 01:02 bernaferrari

CLAs look good, thanks!

googlebot avatar Feb 06 '18 01:02 googlebot