Android-Password-Store
Android-Password-Store copied to clipboard
[BUG] Empty modal for picking public key / No `.gpg-id` file created with PGPainless
Describe the bug
There is no modal that should be presented to pick a PGP public key for encryptions. Normally this/these key(s) would be added to a file named .gpg-id
. If the app is forcibly restarted at this time, the .gpg-id
file is not created and no feedback from the app indicates the failure.
Attempting to pick a key (initial setup -> select key/new folder -> set key for dir) darkens the background, but there is no visible modal.
Possibly related to #1880
Steps to reproduce
Steps to reproduce the behavior:
Initial setup
- Tap on
Let's go
- Setup repo however
- Tap on
Select key
blank screen - Force close app and restart
APS set up with no feedback of failure; no
.gpg-id
file
Folder creation
- Tap on
+
- Choose
Folder
- Enable
Set GPG Key
and set a valid name - Tap
Create
blank screen - Force close app
Folder created; but no
.gpg-id
Expected behavior
- A modal popup to pick public key
- Failure/interrupt during this modal should a. Revert initial setup b. Not create a folder
Screenshots
Inital setup screen at Pick GPG step
Blanked out screen after tapping on "Select key" button
Device information
- Device: Windows Subsystem for Android
- OS: Android 11
- App version: SNAPSHOT e025b120ed18668418e8cf66830a0590dbc4ab08
Additional context
Checked presence of .gpg-id
using adb shell
with run-as dev.msfjarvis.aps.debug
Creating new repos isn't fully supported with PGPainless yet, primarily because none of the key management UI is built out. There is no .gpg-id
because that button launches GetKeyIdsActivity which is very clearly just OpenKeychain code.
ah, gotcha. i was testing around and thought it might be related to #1880 where passwords weren't being encrypted with the public key
Fixed by c4edf7f0e6203037384b042c8d450fb180d0c0f0