DiscordTokenProtector icon indicating copy to clipboard operation
DiscordTokenProtector copied to clipboard

Compilation failure due to PolyHook 2 dependency

Open ambiennt opened this issue 2 years ago • 1 comments

Changes to the PolyHook 2 dependency seem to have caused this project to not compile. I believe this commit to PolyHook 2 caused the problem, as it removed PLH::CapstoneDisassembler and its respective header.

image image
As a temporary workaround, I attempted to use old versions of PolyHook with vcpkg. vcpkg does permit installing specific package versions (such as the most recent one of PolyHook before the above commit) in manifest mode. However, I've been unsuccessful in configuring that after trying for some time:

{
  "name": "dtp",
  "version-string": "0.0.1",
  "dependencies": [
    "polyhook2"
  ],
  "builtin-baseline": "16ee2ecb31788c336ace8bb14c21801efb6836e4",
  "overrides": [
    { 
        "name": "polyhook2", 
        "version": "2023-02-24"
    }
  ]
}

vcpkg install --triplet x86-windows-static (in manifest mode) image

Versions 2023-05-16 and later of PolyHook 2 do compile as a package. But they include the problematic changes as mentioned above, so this doesn't really fix anything.

ambiennt avatar Dec 01 '23 12:12 ambiennt

I fixed the issue on a pull request, read the details and have fun

GuardianN06 avatar Mar 22 '24 17:03 GuardianN06