Andrew Johnson
Andrew Johnson
Perfect, thanks
@t4c1 There's an odd failure of the expression tests here: ``` [ RUN ] ExpressionTestPrim.poisson_lcdf585 ./test/expressions/expression_test_helpers.hpp:101: Failure Expected equality of these values: a Which is: -726.65 b Which is: -726.65...
Ah sorry for the ping, figured it out
> Now I'm curious. I'm guessing the test uses more precision than the print. Yep, there was a numerical difference because one of the captured scalars was falling out scope,...
Closing for now to clear PR backlog, will re-open once ready for review
@serban-nicusor-toptal There's an odd Git failure on the Jenkins run, any chance you've seen something like this before>
> Thanks for looking into this @andrjohns. I guess the downside to this approach is losing the ability to 'batch' calls? Yeah pretty much. I was thinking an option would...
Sorry for the delay in getting to this @bob-carpenter! Ready for another look now
@WardBrian I've updated the test model to include various containers (to make that the un-constraining works correctly), and verified that the returned values are consistent with those returned by `cmdstanr`
Sounds interesting, will take a look!