Andrew Johnson
Andrew Johnson
No worries! I don't really have a preference either way, so I'm happy with whichever option would be easiest on the implementation side
This is because `cmdstanr` will use the R session temporary directory for the sampling outputs by default, when you re-render the temporary directory may have changed and so the sampling...
@jgabry any chance you're familiar with quarto and caching? I wonder if there's a specific change we need to make to enable `CmdStanFit` objects to be cached with the draws...
I'm generally in favour of move-semantics, but are we ready to start enforcing a c++17 minimum with `if constexpr`? That implies a hard requirement for the next Stan version to...
Ah I didn't pay attention to the actual warning, well that makes sense to me then! I'll give this a proper review tomorrow
No wokkas, feel free to ping me when it's sorted
Hmm most likely, there aren't any other parser bugs with 2.32 that I'm aware of. Let me know if removing the `#` doesn't fix things - then there could be...
We add `GNU make` as a requirement since the makefiles use `shell` calls for setting compiler flags (in the same way as the `RcppParallel` package), which isn't standard POSIX-make syntax...
Ah yes that's not referring to `GNU make`. Do you have `SystemRequirements: C++11` or similar in your `DESCRIPTION` file?
Got it! In that case you can just provide my comment above as a response from the rstan devs for why we add `GNU make` (or link to this github...