Andrew Johnson

Results 456 comments of Andrew Johnson

> Does building RcppParallel work as expected on your machine with this change? If so, what OS are you using? > > If we can fix or work around the...

Brilliant, thanks!

Also opened an issue upstream with `oneTBB` for the linking issue: https://github.com/oneapi-src/oneTBB/issues/1392

@georgestagg I found a [discussion](https://github.com/oneapi-src/oneTBB/issues/654) about a similar error where a flag for disabling the build of `itt_notify` was recommended. I've added it to the recipe here and it's fixed...

> Ah, I see. The error remains because my host version of RCppParallel has not changed. It does not link to oneTBB and includes headers such as tbb/include/tbb/tbb_machine.h without Emscripten...

> The vendored tbb headers in RCppParallel will also need to be modified to recognise __EMSCRIPTEN__ as a valid Unix-style machine, and the modified headers updated on the host machine...

It's not the 'cleanest' solution - but could the build call check for a dependency on `RcppParallel` and if found, once the [dependencies are installed](https://github.com/r-wasm/rwasm/blob/f5fc2feb150b13601226fd0478535d67956fa2fa/R/build.R#L177) then temporarily replace the `include/tbb`...

In general, how does the cross-compilation handle situations where a package needs to link against another package and include headers from the other package? Can it be configured to link/include...

Yeah the different symbols are caused by different headers unfortunately - RcppParallel includes the older "TBB" library, and there were some significant API changes when Intel changed to "oneTBB" -...

Another one of the Stan devs just let me know that the current oneTBB has a bug which affects [static/WASM initialisation](https://github.com/oneapi-src/oneTBB/pull/1346), so this will have to wait until the next...