reflow-maven-skin icon indicating copy to clipboard operation
reflow-maven-skin copied to clipboard

Skin does not work with Maven Site Plugin 3.5

Open bindul opened this issue 8 years ago • 10 comments

The changes introduced in Maven Site Plugin breaks the skin. Maven Site 3.5 introduced some non backward compatible changes From 3.4 to 3.5

Among other issues, the body is rendered as:

<div class="body-content">
$bodyWithHeader
</div>

bindul avatar Mar 01 '16 03:03 bindul

The root problem is that the new Maven Site plugin is not loading Velocity tools.

See: http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html

Bernardo-MG avatar May 23 '16 22:05 Bernardo-MG

I am experiencing the same issue and a fix would be highly appreciated.

marvec avatar May 26 '16 21:05 marvec

As I've been completely unable to find a fix to this problem, and it seems everybody else is in the same situation, I've opened an issue for the Maven Site plugin: https://issues.apache.org/jira/browse/MSITE-782

Bernardo-MG avatar Jul 25 '16 21:07 Bernardo-MG

This issue has been fixed in https://issues.apache.org/jira/browse/DOXIASITETOOLS-168 and needs some trivial changes in this plugin.

michael-o avatar Oct 15 '16 13:10 michael-o

Thanks for the fix

Bernardo-MG avatar Oct 16 '16 20:10 Bernardo-MG

Recently tried with Maven Site Plugin 3.6 and this issue is not fixed :(

solomax avatar Dec 08 '16 05:12 solomax

@solomax, as noted above (by @michael-o):

This issue has been fixed in https://issues.apache.org/jira/browse/DOXIASITETOOLS-168 and needs some trivial changes in this plugin.

The plugin still needs a change, I believe around moving reflow-maven-skin/reflow-velocity-tools/src/main/resources/tools.xml to META-INF/maven/site-tools.xml (or moving it there during the build), as suggested in DOXIASITETOOLS-168 comment-15578066.

Have not tested.

bindul avatar Dec 08 '16 06:12 bindul

I've updated my own skin for working with Maven Site 3.6: https://github.com/Bernardo-MG/docs-maven-skin

As commented, from now on any custom tool should move the tools.xml file to META-INF/maven/site-tools.xml

Bernardo-MG avatar Dec 09 '16 09:12 Bernardo-MG

Should we fork this project? @andriusvelykis does not seam to be active on this repo any more (for about 5 years now)

Ordiel avatar Apr 22 '19 04:04 Ordiel

@Ordiel we are using this one https://github.com/devacfr/reflow-maven-skin

solomax avatar Apr 22 '19 04:04 solomax