andreymal comments

Results 116 comments of


                                            andreymal

Packed Arrays could use some more trait impls

I want `AsRef` for `PackedByteArray` to store it as a reader in some Rust code, something like: ```rust pub struct SomeSmartParser { input: std::io::Cursor, } ``` In real code, this...

Packed Arrays could use some more trait impls

>should we then consider implementing `Read` + `Seek` ... on the container directly? You can't because you need to store the cursor position somewhere (but the `Write` implementation can be...

Packed Arrays could use some more trait impls

Regarding `AsMut`, https://github.com/rust-lang/rust/pull/92663#issuecomment-1007877697 mentions that this implies a fixed-size buffer, which is not good An alternative is implementing our own `pub struct PackedByteArrayCursor { inner: PackedByteArray, pos: u64, }` but...

Packed Arrays could use some more trait impls

>What does [this doc](https://doc.rust-lang.org/std/io/struct.Cursor.html#) mean then? `impl Write for Cursor` is implemented for `&mut [u8]`, `Vec` and `Box`, all these types implement `AsRef`, maybe this is what this doc mean...

Allow custom receivers in virtual methods

Just ran into this issue when I tried to test #883 ```rust #[derive(GodotClass)] #[class(editor_plugin, tool, init, base=EditorPlugin)] pub struct MySuperEditorPlugin {} #[godot_api] impl IEditorPlugin for MySuperEditorPlugin { fn enter_tree(&mut self)...

Cannot run quad example in android

I have the same error on my Redmi 4X (Android 6 / MIUI 8.2) I find these lines in the log interesting: ``` 16086 E dex2oat : Failed to create...

Cannot run quad example in android

I think I found the cause: [cargo-quad-apk/src/ops/build.rs:271](https://github.com/not-fl3/cargo-quad-apk/blob/2f5657f9afc4d706dadc2dbf9c0a64df9959f795/src/ops/build.rs#L271-L272): ```rust d8_cmd.arg("--min-api") .arg("26"); ``` Replacing it with `.arg(config.min_sdk_version.to_string());` fixed this error, but then I got another error: ``` 18866 W linker : /data/app/rust.quad_test-1/lib/arm64/libquad_test.so:...