pysmartthings icon indicating copy to clipboard operation
pysmartthings copied to clipboard

Add veryFineDustSensor Capability

Open LeeHanYeong opened this issue 1 year ago • 3 comments

https://developer.smartthings.com/docs/devices/capabilities/capabilities-reference/#veryFineDustSensor It indicates the level of very-fine dust (PM1.0) in air monitors, air purifiers, and air conditioners.

Description:

Related issue (if applicable): fixes #

Checklist:

  • [x] The code change is tested and works locally.
  • [x] Local tests pass.
  • [x] There is no commented out code in this PR.
  • [x] Tests have been added/updated and code coverage percentage does not drop. No exclusions in .coveragerc allowed
  • [x] README.MD updated (if necessary)

LeeHanYeong avatar Jul 29 '23 15:07 LeeHanYeong

Hi @LeeHanYeong!

I came here for the same thing :)

I've sent GH-78 which adds veryFineDustLevel as an attribute to the single dustSensor, that seems to be consistent with how the existing dustLevel and fineDustLevel attributes are implemented.

Hopefully at least one of our PRs will get accepted :)

baawiki avatar Sep 10 '23 22:09 baawiki

@LeeHanYeong just following the earlier comment, I've dropped my pull request as we don't need two for the same feature.

The only thing I see missing from yours is an update on the CAPABILITIES_TO_ATTRIBUTES map. I think you need to add:

"veryFineDustSensor": ["veryFineDustLevel"],

somewhere around line 140.

HTH!

baawiki avatar Sep 11 '23 07:09 baawiki

@baawiki Thanks for the help with the missing code. @andrewsayre I added the above code to my PR.

LeeHanYeong avatar Sep 19 '23 03:09 LeeHanYeong