libgroove icon indicating copy to clipboard operation
libgroove copied to clipboard

“error: 'filename' is deprecated” when trying to build from master

Open stormwatch opened this issue 5 years ago • 4 comments

cmake -Wno-error=deprecated-declarations runs succesfully but then make fails:

/usr/local/src/libgroove/src/file.c:108:5: error: 'filename' is deprecated [-Werror=deprecated-declarations] file->filename = f->ic->filename;
^~~~
In file included from /usr/local/src/libgroove/src/file.h:16:0,
from /usr/local/src/libgroove/src/file.c:8: /usr/include/ffmpeg/libavformat/avformat.h:1408:10: note: declared here char filename[1024];
^~~~~~~~
...

I added -Wno-error... to cmake because I saw it in #126

Any advice on how to go on?

stormwatch avatar Jul 10 '18 23:07 stormwatch

same error , OSX Mojave

jimmyyao88 avatar May 21 '19 16:05 jimmyyao88

same problem with ffmpeg 4.2.1 on master branch

how to get around this?

molecular avatar Sep 27 '19 21:09 molecular

@molecular this is from breaking api changes in ffmpeg, for example with filename, it is deprecated in favor of using "url" which is just a char* instead of a fixed sized array.

@andrewrk I'm down to put work into fixing some code rot, would you also be into using conan as a package manager? (it certainly would simplify building from source)

mattnite avatar Nov 03 '19 20:11 mattnite

Same error while building the library

sauntheninja2 avatar May 08 '22 09:05 sauntheninja2