groovebasin icon indicating copy to clipboard operation
groovebasin copied to clipboard

Won't stop "playing" song when over

Open eyecreate opened this issue 10 years ago • 8 comments

It seems a little too often, groovebasin keeps thinking it's playing a song after it's over and has to have someone intervene and select another song to continue. Not sure if it's file error or not, but file seems fine outside of groovebasin. http://i.imgur.com/sRDBWqx.png

eyecreate avatar Oct 30 '14 14:10 eyecreate

Can you determine if this is the same issue as #297 ?

There is a bug where if you change what song will be playing next within about 10 seconds of the current song, it can fail to go to the next track. Does this issue occur when you did not change the next track within 10 seconds of the current one ending?

andrewrk avatar Oct 30 '14 17:10 andrewrk

This happens even when no songs were being moved around or other interaction it seems On Oct 30, 2014 1:15 PM, "Andrew Kelley" [email protected] wrote:

Can you determine if this is the same issue as #297 https://github.com/andrewrk/groovebasin/issues/297 ?

There is a bug where if you change what song will be playing next within about 10 seconds of the current song, it can fail to go to the next track. Does this issue occur when you did not change the next track within 10 seconds of the current one ending?

— Reply to this email directly or view it on GitHub https://github.com/andrewrk/groovebasin/issues/384#issuecomment-61130724 .

eyecreate avatar Oct 30 '14 17:10 eyecreate

One more thing to check, do you have more than a couple DRM'd songs in your library? One other known issue is #161 - if 4 songs in a row have DRM it can cause this issue.

andrewrk avatar Oct 30 '14 17:10 andrewrk

I'm pretty confident the songs have no DRM. On Oct 30, 2014 1:47 PM, "Andrew Kelley" [email protected] wrote:

One more thing to check, do you have more than a couple DRM'd songs in your library? One other known issue is #161 https://github.com/andrewrk/groovebasin/issues/161 - if 4 songs in a row have DRM it can cause this issue.

— Reply to this email directly or view it on GitHub https://github.com/andrewrk/groovebasin/issues/384#issuecomment-61136934 .

eyecreate avatar Oct 30 '14 17:10 eyecreate

Looked through the logs and found this: Error opening .mp3 error: open file failed This might explain in that it couldn't open the next file. Would have expected it to skip it. On Oct 30, 2014 1:48 PM, "Eyecreate" [email protected] wrote:

I'm pretty confident the songs have no DRM. On Oct 30, 2014 1:47 PM, "Andrew Kelley" [email protected] wrote:

One more thing to check, do you have more than a couple DRM'd songs in your library? One other known issue is #161 https://github.com/andrewrk/groovebasin/issues/161 - if 4 songs in a row have DRM it can cause this issue.

— Reply to this email directly or view it on GitHub https://github.com/andrewrk/groovebasin/issues/384#issuecomment-61136934 .

eyecreate avatar Oct 30 '14 18:10 eyecreate

You're right that the correct behavior is to skip it. Thank you for finding that though, that is a clue that can help me troubleshoot and try to replicate the bug so I can fix it.

Did it say why the open file failed? (edit: never mind, I see in the source code that it will only say error: open file failed in that situation.)

andrewrk avatar Oct 30 '14 21:10 andrewrk

No, but the fact when I went to delete the file through the GUI it complained also with enoent error could mean the file didn't exist anymore On Oct 30, 2014 5:35 PM, "Andrew Kelley" [email protected] wrote:

You're right that the correct behavior is to skip it. Thank you for finding that though, that is a clue that can help me troubleshoot and try to replicate the bug so I can fix it.

Did it say why the open file failed?

— Reply to this email directly or view it on GitHub https://github.com/andrewrk/groovebasin/issues/384#issuecomment-61173787 .

eyecreate avatar Oct 31 '14 15:10 eyecreate

This is happening to me consistently at the end of the final song in the queue when

  • there are at least 6 songs in the queue
  • repeat is set to All

It seems to happen regardless of which songs are in the queue and regardless of whether any streamers are connected. It's happening in both the 1.4.0 release and the current master. I also managed to trigger segfaults twice while trying to narrow down the cause, which makes me suspect there might be an underlying problem in libgroove. I see an encoder: end of playlist sentinel message in the log when the end of the track is reached, but nothing else.

kalgynirae avatar Nov 21 '14 00:11 kalgynirae