Andrew Pollock
Andrew Pollock
@masterismail there's some linter errors on your change: ``` gcp/api/server.py:440:0: W0311: Bad indentation. Found 4 spaces, expected 2 (bad-indentation) gcp/api/server.py:441:0: W0311: Bad indentation. Found 8 spaces, expected 4 (bad-indentation) gcp/api/server.py:442:0:...
@masterismail there's still some formatting errors with this change. Have you run https://github.com/google/osv.dev/blob/master/tools/lint_and_format.sh on it locally? If you run `yapf -i gcp/api/server.py` it should fix them.
> this is what I am getting Hi, have you set up your local development environment per https://github.com/google/osv.dev/blob/master/CONTRIBUTING.md#contributing-code? Actually, reviewing that in conjunction with the output you've screenshotted, I can...
> yes, I did Yes, it turns out there were a few things necessary that weren't explicitly in the documentation, see the #1542 for what else you need to have...
> yes, i'm able to see those test fails Cool, do you understand what you need to do to get your PR to pass, based on the failure?
> I don't understand why its actually failing, it rates my code 10/10 `pylint` is happy with the change, `yapf` is not: ``` --- gcp/api/server.py (original) +++ gcp/api/server.py (reformatted) @@...
@masterismail checking back in to see if you plan on completing this, or if we should close it?
Hi Krzysztof, not sure if you're asking for an update with respect to the work overall, or an update in relation to https://github.com/google/osv.dev/issues/783#issuecomment-1354670824 specifically? I can give a progress update...