Found a bug with some stranger bytes in date conversion and copy file as default

[berlotto]

[andrewning]

I consciously made move the default behavior because this is how the script primarily used. The move operation is atomic so it's not really any less safe.

On Thu, Dec 4, 2014 at 9:29 AM, Sérgio H. Berlotto Jr [email protected] wrote:

You can merge this Pull Request by running: git pull https://github.com/berlotto/sortphotos master Or you can view, comment on it, or merge it online at: https://github.com/andrewning/sortphotos/pull/32 -- Commit Summary --

• Remove special and null bytes from the string for convert correctly

• Change 'copy' as default to be more secure, added -m --move parameter -- File Changes -- M src/sortphotos.py (10) -- Patch Links -- https://github.com/andrewning/sortphotos/pull/32.patch https://github.com/andrewning/sortphotos/pull/32.diff

  Reply to this email directly or view it on GitHub: https://github.com/andrewning/sortphotos/pull/32

[andrewning]

Could you send me one of the photos that causes the null bytes issue for you?  I want to see where the root is and if it's possible that other fields could have these issues. Thanks for your contribution.

On Thu, Dec 4, 2014 at 7:10 PM, null [email protected] wrote:

I consciously made move the default behavior because this is how the script primarily used. The move operation is atomic so it's not really any less safe. On Thu, Dec 4, 2014 at 9:29 AM, Sérgio H. Berlotto Jr [email protected] wrote:

You can merge this Pull Request by running: git pull https://github.com/berlotto/sortphotos master Or you can view, comment on it, or merge it online at: https://github.com/andrewning/sortphotos/pull/32 -- Commit Summary --

• Remove special and null bytes from the string for convert correctly

• Change 'copy' as default to be more secure, added -m --move parameter -- File Changes -- M src/sortphotos.py (10) -- Patch Links -- https://github.com/andrewning/sortphotos/pull/32.patch https://github.com/andrewning/sortphotos/pull/32.diff

  Reply to this email directly or view it on GitHub: https://github.com/andrewning/sortphotos/pull/32