(Rew) Andrew McLagan comments

Results 113 comments of


                                            (Rew) Andrew McLagan

Ignore errors with husky precommit hook

add the files to the ignore list

Ability to extend the JWT token with information

Agree with @uphlewis, even if `convertToJWT()` returned an instance of `Builder` and not `Token` we could extend the trait and modify the token returned in `__toString()`

Corcel integration with Lighthouse GraphQL

Honestly why not just use the very well supported JSON api in Wordpress and save yourself some moving parts and maintaining

There is a lack of documentation on how to use sort

+ 100

There is a lack of documentation on how to use sort

```php use ONGR\ElasticsearchDSL\Sort\FieldSort; $search->addSort(new FieldSort('_score', 'ASC')); $search->addSort(new FieldSort('title', 'ASC')); ```

Switch from moment to date-fns?

I would be very interested in this, date-fns has gained allot of traction and looking forward seems to have allot more momentum and a better footing.

Switch from moment to date-fns?

Agreed. Although, without digging too much @ljharb do you think there is allot of work to swap out implementations?

[Flow] Export each possible variant of a union as a separate type

Also need this.

Converting back to JSON

If this library implemented the official FormData API specifications we would be able to iterate over instances and return key value pairs.

Strive for symmetrical API to browsers FormData.

Any traction on this? A unified API would be amazing.