Andrew Maguire

Results 290 comments of Andrew Maguire

👋 I have a similar need and tried to open #30005 as a small change that would get me what I need. But probably being able to pass in a...

@Ferroin how will this effect existing issues? Would we need some sort of script to relabel them based on new mapping etc? or is that somehow something that can be...

hmm not sure how to fix that failing test: > FAILED tests/test_public_functions.py::test_function_param_validation[sklearn.inspection.permutation_importance] - AssertionError: Mismatch between _parameter_constraints and the parameters

> @andrewm4894 Actually, we had a similar feature request in the past: #18694 @glemaitre oh interesting, I had thought about similar but felt this change a bit smaller and simple...

Although @glemaitre this is a small and simple pr here while you linked to an issue but not sure if there is a draft pr anywhere? (I will try think...

@glemaitre 👋 i made some changes [here](https://github.com/scikit-learn/scikit-learn/pull/30005/commits/84d8adb7f93e4efafd73380811a6cfc360bae3f1) to switch to `feature_indices` approach that i think matches sort of api desired in #18694 this way user can just pass in a...

@glemaitre 👋 do you think the updated approach in this pr to use the more flexible API is a way forward? I'm a little bit blocked by this in work...

@glemaitre any idea if I can find someone to try help me get this reviewed and merged over next few weeks?

@glemaitre any idea if i can try make another run at seeing if feasible to consider getting this merged?

still would benifit from this if anyone could take a look