NetEscapades.Configuration icon indicating copy to clipboard operation
NetEscapades.Configuration copied to clipboard

Handle merge references correctly

Open otsenkun opened this issue 4 years ago • 3 comments

fixes #59

otsenkun avatar May 18 '21 10:05 otsenkun

Hi,

Thanks for the work you've done already :) Let me know if I missed anything on this pull request

otsenkun avatar May 18 '21 10:05 otsenkun

Hi @andrewlock, I was wondering if you can take a look at this anytime soon :)

otsenkun avatar May 18 '21 19:05 otsenkun

Hi @otsenkun, thanks for this, merge keys aren't something I've ever run into! Unfortunately, this will technically be a breaking change, so I think we may need to put the behaviour behind a feature flag.

Also, would it be possible to add some additional tests for basic Anchors and Aliases (without merge keys), just to confirm we haven't changed existing behaviour?

Thanks!

andrewlock avatar May 26 '21 22:05 andrewlock