Andrew Lee
Andrew Lee
To record some of the things that were discussed at the Core Dev meeting: 1. From the physical modeling perspective, these points are generally excluded as these are conditions at...
Additional thoughts: 1. For rate reactions in a single phase system, calculating the generation base on the inlet conditions is probably a good approximation of the generation at 0+. How...
1. To give an example, what does the reaction generation term mean at the boundary? This starts getting at the fundamental assumptions we make as modelers - i.e. that nothing...
1. Whilst it might not be physically true, that is the meaning that is traditionally assigned at the boundary. In many ways, this is just a convention, but it is...
@eslickj I was thinking about what the return myself, and my first thought was `NaN` as well (followed by recognizing the same issue you did). I think we want a...
Probably the short answer here for why we did this is a) I was learning Python as I went and b) to distinguish scope in sub models. E.g. ``` def...
From the coding perspective, I don't think there is nay problem with changing everything to `self`. However, given that our target audience is chemical and process engineers, I wonder if...
@lbianchi-lbl Yes, that is along the lines of what I was thinking, but unifying to have only one accepted "semantically relvaent" name for the sub-methods (so either `m` or `b`...
@lbianchi-lbl I agree - we should take this opportunity to fix the codebase to resolve this. However, we would need to discuss what is required (i.e. where we should use...
@OOAmusat Any update on this issue? I assume it is not making it into the August release at this point,