immutable-devtools icon indicating copy to clipboard operation
immutable-devtools copied to clipboard

Typo in renderIterableBody?

Open benny-medflyt opened this issue 6 years ago • 0 comments

Hi, I was reading through the code of this library, and read the renderIterableBody function. Here is the source for it:

  const renderIterableBody = (collection, mapper, options = {}) => {
    if (options.sorted) {
      collection = collection.sortBy((value, key) => key);
    }
    const children = collection
      .map(mapper)
      .toList();

    const jsList = []
    // Can't just call toJS because that will also call toJS on children inside the list
    children.forEach(child => jsList.push(child))

    return [ 'ol', listStyle, ...children ];
  }

It seems that the author carefully crafted the jsList list, but then forgot to use it, and mistakenly used children instead.

benny-medflyt avatar Jan 02 '19 14:01 benny-medflyt