koudoku icon indicating copy to clipboard operation
koudoku copied to clipboard

Subscription quantity

Open skalb opened this issue 11 years ago • 5 comments

Do you see any issues adding support for the quantity parameter?

In addition to having a config default quantity per plan, I'd like to add a method to set the quantity at a later point on a given subscription.

Ideas on how to best implement this?

skalb avatar Nov 06 '13 17:11 skalb

I can't foresee any real issue implementing this. I recommend just forking the repo and creating a feature branch for this. It seems to me that you could pretty easily add a quantity select field on the credit card form, add a corresponding field to the subscription model, and add the logic that ensures this is passed to Stripe as well. You'd also have to give thought to how quantity would affect things like displaying the current plan price, etc. on the view/edit subscription page.

andrewculver avatar Nov 17 '13 01:11 andrewculver

What are you using subscription quantities for? I know that Stripe supports them, but I'm not sure whether they're something Koudoku would support in the master branch, since I've never run into anyone who uses them before.

andrewculver avatar Nov 17 '13 01:11 andrewculver

I actually didn't end up needing quantity for now, at least. I think the use case isn't that rare. For example, a SaaS site that charges per/user.

skalb avatar Nov 17 '13 03:11 skalb

Yeah, great example. I think what I would prefer to do is wait for someone who is actually charging per-user for a service submit a pull request for this functionality. I'll have to advertise that we're looking for this contribution somehow. :-)

andrewculver avatar Nov 19 '13 16:11 andrewculver

@andrewculver do you think this could be merged as-is?

ericgross avatar Jun 20 '16 18:06 ericgross