ParserCombinator.jl icon indicating copy to clipboard operation
ParserCombinator.jl copied to clipboard

Make work in 0.6

Open oxinabox opened this issue 7 years ago • 13 comments

Ok this is building on #26 and #21

I'm not saying this is the prettiest code, but it passes all tests.

In a few places I got rid of inner constructors, and replaced them with outer constructors. They are much more sensibly behaved, being just functions. I'ld like to do that everywhere, but for now I am happy just to have it working.

I also drop all support for 0.5. And remove Compat. Its just easier to stop maintaining old versions (at least til 1.0) (In my opinion) Particularly given this package is stable so the version to version difference is likely just deprecation fixes

oxinabox avatar Nov 26 '17 12:11 oxinabox

@CarloLucibello @sbromberger @andrewcooke

oxinabox avatar Nov 26 '17 12:11 oxinabox

Coverage Status

Coverage decreased (-3.03%) to 84.84% when pulling 3ea799e16a2a352f40c89a1ec93ccc188cfe60f8 on oxinabox:oxff6 into a0c0da6cbaa98ed707d4290c899589e7833dbec5 on andrewcooke:master.

coveralls avatar Nov 26 '17 12:11 coveralls

Hi, thanks for doing this, I got stucked at a certain point.

There are a few tests that cuold/shoud be reactivated (where you see TODO), and some @compat calls in test/ that could be removed

CarloLucibello avatar Nov 26 '17 12:11 CarloLucibello

Thanks for the feedback. I'll poke this tomorrow or so. Huh, I didn't realize that the tests had compat nor that they were changed .(I guess they were changed in your PR)

oxinabox avatar Nov 26 '17 13:11 oxinabox

Coverage Status

Coverage decreased (-2.8%) to 85.118% when pulling 2f7267f0f0f61314fcb522054fc112beffacda8d on oxinabox:oxff6 into a0c0da6cbaa98ed707d4290c899589e7833dbec5 on andrewcooke:master.

coveralls avatar Nov 27 '17 02:11 coveralls

Bump. Looks like that worked, still losing a few lines on coverage though.

oxinabox avatar Dec 06 '17 09:12 oxinabox

@andrewcooke could you grant write permissions to @oxinabox and me?

CarloLucibello avatar Dec 06 '17 10:12 CarloLucibello

@CarloLucibello can you review and merge if ready?

oxinabox avatar Jan 04 '18 07:01 oxinabox

tests are passing, although the output around this line looks not properly formatted. I don't know if it is just a problem with tests or we are really loosing something. If you manage to fix this good, otherwise let's just merge.

CarloLucibello avatar Jan 05 '18 06:01 CarloLucibello

I can't see any changes that could have been causing that on a quick look.

But the last builds for the 0.5 current master don't screw up like that https://travis-ci.org/andrewcooke/ParserCombinator.jl/jobs/152686452

oxinabox avatar Jan 05 '18 07:01 oxinabox

Oh did this never get merged?

oxinabox avatar Jun 22 '18 02:06 oxinabox

tests are passing and there are no warnings left. I think there are still some problems to be addressed though, some part of the tests' output looks incorrect:

/4        expr 3.0-4.0-4.0*(3.0*7.0+0.0-0.0)+6.0*3.0+2.0 
09-65.0 -65.0 
         calc okDepth
->one levelAlt

    66::ab        /4          0101  AltTrace->->divDot

    22::/4        b           110 0  div->TraceSeq<-
['a'] 
 multiple7 
:  4         2  :212ab        :  b           0 Seq00-> 0neg 
Trace ->Trace Dot->7
Depth:   :
4                       1300 0:    b         Alt ->Trace0Transform<-!!!
1
    Depth7->:Dot4         
  14  1    :Transform          -> Pattern0
1   :             Depth14<- ['b']    
Transform <-!!!
    :3          :           13  0   1Alt <-!!!
  Depth ->7Dot:

CarloLucibello avatar Jun 22 '18 04:06 CarloLucibello

I can't workout (just from reading) what is causing all these extra displays. I am tempted to try and mock STDOUT with something that will throw an exception at the point where the extra output is printed.

oxinabox avatar Jun 22 '18 05:06 oxinabox