civs icon indicating copy to clipboard operation
civs copied to clipboard

feat: switch off BerkeleyDB

Open nyabinary opened this issue 1 year ago • 5 comments

The license change and generally instability (anecdotally speaking) with BerkeleyDB makes it a strong candidate for replacement with a different DB backend.

nyabinary avatar Oct 19 '24 21:10 nyabinary

I am open to suggestions for a replacement.

andrewcmyers avatar Oct 19 '24 22:10 andrewcmyers

I am open to suggestions for a replacement.

SQLite?

nyabinary avatar Oct 20 '24 00:10 nyabinary

I need a key-value store with strong consistency guarantees. SQLite seems like a bad fit on both dimensions.

andrewcmyers avatar Oct 20 '24 01:10 andrewcmyers

I need a key-value store with strong consistency guarantees. SQLite seems like a bad fit on both dimensions.

PostgreSQL? Etcd? TiKV? There is also RocksDB, but that requires a layer for consistency.

nyabinary avatar Oct 20 '24 14:10 nyabinary

I don't see a reason to believe that BDB is less reliable than any of these systems, since I've only seen one apparent problem in 20+ years. But if someone wants to explore alternatives I am happy to look at PRs. It would need to be an option rather than a replacement in any case, for backward compatibility.

andrewcmyers avatar Oct 20 '24 21:10 andrewcmyers