Andrew Branch

Results 261 comments of Andrew Branch

`.cts` file extensions in `module: esnext` is a contradiction, and there are no plans to make it meaningful at the moment—if anything, it should probably be a program-level error. If...

Because its typings are wrong. clsx is a CJS library, but its typings say `export default`. https://unpkg.com/browse/[email protected]/clsx.d.ts

@weswigham honestly, I think we should consider making `export default` in CJS-scoped declaration files an error under node16/nodenext, with a message that says the library is probably wrong, similar to...

Well, maybe not until `--module commonjs` and `--module esnext` report an error on a file in a conflicting format.

This was backed out of 5.5—hoping to reintroduce a fix in 5.6 via #58825.

Yep, I’m having this issue too. Took me forever to diagnose. This plugin just randomly blows out other assets. Maybe I’ll open a PR... What are the advantages of using...

Investigated: the offending code begins in `_cleanupBucket`: ``` js if ((data.Contents.length - this.manifestSize) > 0) { var itemsToDelete = this._getItemsForDeletion(data); console.log(itemsToDelete); this._deleteItemsFromBucket(itemsToDelete) .then(resolve) .catch(reject); } ``` The implementation of `_getItemsForDeletion`...

I understand that. I didn’t at first, but by the time I dove into the source and filed this issue, I had a pretty complete picture of the process. But...