Andrew Branch

Results 250 comments of Andrew Branch

This crash appears to have been fixed already. @typescript-bot will tell us what the fix was.

For some reason the crash isn’t reproducing in the repro runner, but it was fixed between 4.9 and 5.0.

@justinfagnani does the loader in question care about the lack of `"type": "module"` in the root package.json, or can it be pointed to the existing tslib.es6.js? I would think that...

I’ve been giving this a try, and am encountering the same issue. Here are some logs showing a switch from an Apple TV called "Living Room" to my Mac Mini,...

Yeah, I think there is something weird with `typeof` narrowing here. Slightly simplified to extract from #32365: [Playground](https://www.typescriptlang.org/play?ts=4.9.0-dev.20220907#code/JYOwLgpgTgZghgYwgAgGIHt3IN4FgBQyRycAXDsgEbkDOYUoA5sgL4Fv4EwCuICYwdCGQwAPAGlkEAB6QQAExrIA1hACe6GGkwA+ABQxyABThQBcADaiM6ANriAujoA0K8qo1ab9hwEocBMTICEJ0yNLIALwitsoOANyBxMBaemBqAA4QmuHIAISR0QBEvPIQMKAQ8kX+eIRBxBYQYMgA+uTYLFHh8cgA9H3IAMoAFujcFvJSUFDoUFQQCHDcNCg5Geg0NMCUTcgABiATFvuulNwt0LNQSpSLy6vIOful5ZXy+0lEHF-BoS1qbowWIJX4pZB6QEFZCvCogKq1X5BJotdo4LrRNSJerfAi-aS9AbIAAqI2ASnJyAA7hBgFApmBML8sewCEA) ```ts interface Foo { a: { b: string } } function f(f:...

Maybe if a change results in both 1) the removal of a folding range that’s currently folded, and 2) a syntax error that intersects that range, you could leave it...

I don’t think this is actionable without any repro information, unless @sheetalkamat has any ideas about how this assertion could fire: https://github.com/microsoft/TypeScript/blob/c8ec855f9fd5efa2a324b08ad4cc468b4c3013d4/src/server/editorServices.ts#L1525

I’m not 100% sure how it’s happening, but I was unable to reproduce the problem with TypeScript alone (whether with `tsc` or viewing errors in the editor). Also, I know...